-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: might we rename the Try OCaml
button in Learn-OCaml's homepage?
#415
Comments
Hi all (@AltGr @gasche @yurug @EmileRolley @hannelita @asere @lsylvestre and all the Watchers of this learn-ocaml repo :) I know that this question is not critical at all; but if there is some consensus, we may want to include this small change for the upcoming learn-ocaml 0.13 as well (so feel free to react if you have an opinion on my 2 questions above 🙂) |
No strong opinion, but I would find "tutorials" appropriate. You could add |
+1 for "Tutorials" |
Regarding this small question, thanks a lot for your feedback! no objection was raised, so +1 for @gasche's suggestion. I'll open a PR but let's postpone this to learn-ocaml 0.14 (as it's not a critical User Story to appear in the pending 0.13 AFAICT). |
* Rename all relevant identifiers in the code, to avoid any ambiguity; * learnocaml_main.ml: Keep CLI opt --enable-tryocaml for backward-compatibility Close ocaml-sf#415
* Rename all relevant identifiers in the code, to avoid any ambiguity; * learnocaml_main.ml: Keep CLI option --enable-tryocaml for backward-compatibility; Use a dedicated list of old option names Close ocaml-sf#415
* Rename all relevant identifiers in the code, to avoid any ambiguity; * learnocaml_main.ml: Keep CLI option --enable-tryocaml for backward-compatibility; Use a dedicated list of old option names Close ocaml-sf#415
* Rename all relevant identifiers in the code, to avoid any ambiguity; * learnocaml_main.ml: Keep CLI option --enable-tryocaml for backward-compatibility; Use a dedicated list of old option names Close ocaml-sf#415
Hi all,
This is definitely not an urgent question, but I'm opening this issue to get more feedback:
currently (if most learn-ocaml features are enabled), we have the following buttons in the homepage:
I see one potential issue with the first button
Try OCaml
:an online toplevel
,tutorials
feature of Learn-OCaml, which can precisely be customized within therepository/tutorials/
folder.See e.g. the output of
learn-ocaml build --help
:Toplevel
button and that of thePlayground
button (text-editor + toplevel) look fine.Hence the questions
Would you agree to rename this button? if yes:
A. to
Tutorials
?B. to
OCaml Tutorials
?C. to another thing?
If we rename the button, should we also rename the option
--enable-tryocaml
to--enable-tutorials
?But actually I guess the answer to 2. should probably be no, for CLI backward-compatibility…
The text was updated successfully, but these errors were encountered: