Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to specific platform installation instructions #2583

Open
dra27 opened this issue Jul 7, 2024 · 2 comments
Open

Link to specific platform installation instructions #2583

dra27 opened this issue Jul 7, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted

Comments

@dra27
Copy link
Member

dra27 commented Jul 7, 2024

https://ocaml.org/install automatically displays the Windows page when viewed from a Windows machine, but it would be nice if it updated the URL with an anchor (i.e. such that https://ocaml.org/install#windows activates the Windows instructions anywhere and https://ocaml.org/install#{unix,linux,macos,bsd,etc.} activates the Linux instructions) so that it can be referenced directly.
@sabine sabine added good first issue Good for newcomers help wanted labels Jul 11, 2024
@sabine
Copy link
Collaborator

sabine commented Jul 11, 2024

Yes, this would be nice, and also it's a small task that could be contributed by a newcomer.

SisyphianLiger added a commit to SisyphianLiger/ocaml.org that referenced this issue Jul 17, 2024
@SisyphianLiger
Creating branch that solves issue ocaml#2583
3a36c1c
@SisyphianLiger SisyphianLiger mentioned this issue Jul 17, 2024
Merged
sabine pushed a commit that referenced this issue Jul 23, 2024
@SisyphianLiger
Issue #2583: Added OS Anchor Tags to ocaml.org/install (#2600)
e641fe2 
* Updated ocaml.org/install#anchors

* Creating branch that solves issue #2583

* Reverted url/import.ml highlighted changes in install.eml to view, CLI test should pass
@Gbury
Copy link

Gbury commented Sep 30, 2024

I tried using the new anchors, but on my machine (a linux one), if I try to go explicitly to the windows instructions from a link (i.e. https://ocaml.org/install#windows or even by refreshing the webpage after clicking on the windows instructions), the page automatically redirects to the linux installation instructions, which is really counter-intuitive and annoying, since the link was explicitly to the windows instructions.

I guess that's why this issue is not closed yet ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted
Projects
OCaml.org
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gbury @dra27 @sabine