Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pages don't output empty <h1>s #28

Open
sarahmonster opened this issue Dec 28, 2019 · 0 comments
Open

Ensure pages don't output empty <h1>s #28

sarahmonster opened this issue Dec 28, 2019 · 0 comments
Assignees

Comments

@sarahmonster
Copy link
Member

All pages are currently outputting empty <h1> tags:

Screenshot 2019-12-28 at 23 10 35

Not great for accessibility! It looks like we're passing a bunch of data to the PageHeader component, but the component has been simplified to only show children as a prop.

So instead of:
<PageHeader pageTitle={title} summary={summary} description={description} />
the fix would be to use:
<PageHeader>{title}</PageHeader>

Alternatively, we could refine the PageHeader component to accept more props. This tends to be a common pattern I use for sites, so I'm tempted to opt for the latter approach, although I'm happy to hear dissenting opinions. @tofumatt, thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant