You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All pages are currently outputting empty <h1> tags:
Not great for accessibility! It looks like we're passing a bunch of data to the PageHeader component, but the component has been simplified to only show children as a prop.
So instead of: <PageHeader pageTitle={title} summary={summary} description={description} />
the fix would be to use: <PageHeader>{title}</PageHeader>
Alternatively, we could refine the PageHeader component to accept more props. This tends to be a common pattern I use for sites, so I'm tempted to opt for the latter approach, although I'm happy to hear dissenting opinions. @tofumatt, thoughts?
The text was updated successfully, but these errors were encountered:
All pages are currently outputting empty
<h1>
tags:Not great for accessibility! It looks like we're passing a bunch of data to the
PageHeader
component, but the component has been simplified to only show children as a prop.So instead of:
<PageHeader pageTitle={title} summary={summary} description={description} />
the fix would be to use:
<PageHeader>{title}</PageHeader>
Alternatively, we could refine the PageHeader component to accept more props. This tends to be a common pattern I use for sites, so I'm tempted to opt for the latter approach, although I'm happy to hear dissenting opinions. @tofumatt, thoughts?
The text was updated successfully, but these errors were encountered: