Debug links #76
Closed
Debug links #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sass-site-oddbird ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mirisuzanne or @stacyk This is ready for design. |
Closed
|
@jamesnw I added another example, which has all three, and will scroll you down the page a bit. I also wanted one that tests 3 digit gutters here. I also tested it with 4 and 5 and it works, but it is pretty tight at 5. I kept the bullet since I couldn't change the line number associated as there was not semantic link to the line that has a notice in the markup. I attempted to do a bg color pseduo element, but since I didn't know how wide to make it as that column is allowed to grow, I decided this bullet works OK with a few tweaks. This is ready for review. |
|
Moved to sass#1179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the debug console, line numbers are now links to select or position the cursor at the relevant issue. Also, deprecation messages with links are now clickable.
Related Issue(s)
Addresses #75
Steps to test/reproduce
2. Error link
Links should allow you to open in new tab/window with CMD/Shift/Right click, etc.