Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] theme_bewise: revamp theme #922

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

stefanorigano
Copy link
Contributor

@stefanorigano stefanorigano commented Sep 19, 2024

17.4 this PR
image image

task-4178020
part of task-4177975

@robodoo
Copy link
Collaborator

robodoo commented Sep 19, 2024

Pull request status dashboard

@stefanorigano stefanorigano marked this pull request as draft September 25, 2024 13:58
@stefanorigano stefanorigano changed the base branch from master to 18.0 September 25, 2024 14:02
@stefanorigano stefanorigano marked this pull request as ready for review September 26, 2024 10:38
@stefanorigano stefanorigano force-pushed the master-theme_bewise-revamp-sri branch 2 times, most recently from 86bcb43 to 7c9c7e4 Compare September 26, 2024 11:32
Copy link

@xO-Tx xO-Tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanorigano some remarks and it will be good to go 👍

theme_bewise/static/description/theme_bewise.svg Outdated Show resolved Hide resolved
theme_bewise/static/src/js/tour.js Outdated Show resolved Hide resolved
theme_bewise/static/src/js/tour.js Outdated Show resolved Hide resolved
'font-size-base': 1.3125rem,

'font': 'Darker Grotesque',
'headings-font': 'Raleway',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the Raleway should be removed here (since it's no longer used) or you prefer to keep it available ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it should remain available.
I people want to go back to this font it would be handy to find it directly in the list

theme_bewise/views/customizations.xml Outdated Show resolved Hide resolved
@stefanorigano stefanorigano force-pushed the master-theme_bewise-revamp-sri branch 3 times, most recently from def5e57 to e35faad Compare September 27, 2024 16:53
@stefanorigano
Copy link
Contributor Author

@xO-Tx , thanks so much for your review 👍
Branch rebased and remarks applied. Thanks also for the SVG trick ;)

task-4178020
part of task-4177975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants