-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] theme_orchid: revamp theme #948
base: 18.0
Are you sure you want to change the base?
Conversation
8da8e7b
to
10eb2ce
Compare
4b68250
to
5e71bba
Compare
5e71bba
to
d791544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! :)
Here are some comments, including a bunch of nitpicking:
-> this transition doesn't match the jpg preview, + it seems odd to me. It's even more apparent on bigger screens (i.e. 1440p)
The shape is cut + the white color is slightly different
The different color is also visible in the jpg preview
ec45dec
to
9b58b1c
Compare
Hello @agau-odoo thanks so much for your review 👍 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some more comments, mostly nitpicking again, but still a few important issues imo. We're almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay but now we get this on chromium:
I think we should prefer targeting chromium users first (biggest userbase), so if we don't have an easy fix now, let's revert to the previous version and fix this later.
The issue with the different color at the bottom part of this shape is still there
, but again I don't know if this is important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now I see. The issue it's that the font it's not loaded correctly on your side.
It should be "Elsie", see @import
rule in the svg file.
Could you tell tell me if you get error in your console? Somehow the font it's not used and this leads to discrepancies... in my side it's good on Firefox, Chrome and Safari (OSX)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9b58b1c
to
e89b51a
Compare
@agau-odoo , shape removed and screenshoot/svg updated. |
task-4178087 part of task-4177975
e89b51a
to
dbb8884
Compare
task-4178087
part of task-4177975
17.4