Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saas 17.4 mail message format scju #167

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

jaeschwa
Copy link
Contributor

[IMP] *: Improvment of the mail messages

In all the modules improved the message related to the on boarding.
Modified mail messages, fixed redirection, the automatic opening and
the purple dot are not implemented.

Changed the tests accordingly with the new mail message definition.

task-4056239

@jaeschwa jaeschwa requested a review from vava-odoo July 19, 2024 12:54
@jaeschwa jaeschwa force-pushed the saas-17.4-mail-message-format-scju branch 3 times, most recently from 95ff2ca to 62f38cf Compare August 19, 2024 08:30
Copy link
Collaborator

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good, but noted a few things to improve. Thanks @jaeschwa

tests/test_generic/tests/test_industry_requirements.py Outdated Show resolved Hide resolved
tests/test_generic/tests/test_industry_requirements.py Outdated Show resolved Hide resolved
tests/test_generic/tests/test_manifest.py Outdated Show resolved Hide resolved
tests/test_generic/tests/test_xml.py Outdated Show resolved Hide resolved
agriculture_shop/data/mail_message.xml Outdated Show resolved Hide resolved
agriculture_shop/static/src/js/my_tour.js Outdated Show resolved Hide resolved
agriculture_shop/static/src/js/my_tour.js Outdated Show resolved Hide resolved
agriculture_shop/static/src/js/my_tour.js Outdated Show resolved Hide resolved
@jaeschwa jaeschwa force-pushed the saas-17.4-mail-message-format-scju branch from 8fc17dc to 5493ae1 Compare September 5, 2024 09:25
condominium/data/knowledge_article.xml Outdated Show resolved Hide resolved
condominium/data/knowledge_article_favorite.xml Outdated Show resolved Hide resolved
clothing_boutique/data/knowledge_article.xml Outdated Show resolved Hide resolved
certification_organism/__manifest__.py Outdated Show resolved Hide resolved
cake_shop/data/mail_message.xml Outdated Show resolved Hide resolved
bar_and_lounge/data/mail_message.xml Outdated Show resolved Hide resolved
automobile/static/src/js/my_tour.js Outdated Show resolved Hide resolved
micro_brewery/data/ir_model_data.xml Outdated Show resolved Hide resolved
tests/test_generic/tests/test_xml.py Outdated Show resolved Hide resolved
@jaeschwa jaeschwa force-pushed the saas-17.4-mail-message-format-scju branch 2 times, most recently from 3a6cda0 to 046cd58 Compare September 20, 2024 07:00
@vava-odoo vava-odoo force-pushed the saas-17.4-mail-message-format-scju branch 5 times, most recently from 31fb5bd to 15a216b Compare September 27, 2024 12:57
@vava-odoo vava-odoo changed the base branch from saas-17.4 to 18.0 September 27, 2024 12:57
Added the knowledge tour to all industry modules so when a DB is started
a tour pointing to the knowledge app is directly launched.

To avoid the maintenance lines of code for these tours, these files are
added in the cloc_exclude of the manifest, leading to the automatic
creation of ir_model_data entries to exclude the cloc.
This change is related to this PR: odoo/odoo@a47de680de14

In all the modules, the message related to the onboarding is improved.

task-4056239
@vava-odoo vava-odoo force-pushed the saas-17.4-mail-message-format-scju branch from 15a216b to acac5e7 Compare September 27, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants