Skip to content
This repository has been archived by the owner on Jun 11, 2018. It is now read-only.

OpbeatLogMiddleware is unfinished/undocumented #121

Open
beniwohli opened this issue Aug 5, 2016 · 2 comments
Open

OpbeatLogMiddleware is unfinished/undocumented #121

beniwohli opened this issue Aug 5, 2016 · 2 comments
Assignees
Milestone

Comments

@beniwohli
Copy link
Member

beniwohli commented Aug 5, 2016

We need to actually use the request from the threadlocal if it is set

@beniwohli beniwohli added this to the 3.4 milestone Aug 5, 2016
@beniwohli beniwohli self-assigned this Aug 5, 2016
@Geekfish
Copy link

Geekfish commented Aug 5, 2016

Hey @piquadrat ! I was linked to this from your very helpful support message.
In my tests, enabling the middleware seems to have the expected result already.
It looks like the request is already passed back to the handler? (https://github.com/opbeat/opbeat_python/blob/3.3.4/opbeat/contrib/django/handlers.py#L34)

Is there another component that is missing?

@beniwohli
Copy link
Member Author

Ah, right, for logging handlers the request is already grabbed from the threadlocal. For full support, we also need to grab it in DjangoClient.capture.

But great to hear that the current state already fulfils your requirements!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants