Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: enhance UX on image import, replace "Registry" #864

Open
ikke-t opened this issue Dec 16, 2022 · 2 comments
Open

[Feature Request]: enhance UX on image import, replace "Registry" #864

ikke-t opened this issue Dec 16, 2022 · 2 comments
Labels
community feature/adminui Admin UI Feature good first issue Good for newcomers kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible

Comments

@ikke-t
Copy link

ikke-t commented Dec 16, 2022

Feature description

There is one confusing dialog that has caused misery at customer and partner.
It's small change, but UI is a bit misleading ATM. I've seen failures to import image in different ways, as the term "Repository" and "Name" are misleading. This dialog:

Screenshot from 2022-12-16 11-07-17

First of all, the word repository typically means server url like quay.io, registry.access.redhat.com. So people put those there, and enter the name of image like image:tag into the "name" field, as it can be read that way. Another error I've seen is to put http:// or https:// to "Repository" field.

Describe alternatives you've considered

In minimum, I'd change the Repository -text to "Image URL". Then I'd have an example there, like:

Image URL, e.g.: repository.com:5000/path/image:tag

Anything else?

I've heard from Max Murakami in slack that actually the example of repository.com:5000/path/image:tag is bad, as there is a bug that the dialog will grab anything after first colon as tag. That should be fixed while at it, the regexp should only take anything after the last colon as tag.

@ikke-t ikke-t added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet labels Dec 16, 2022
@shalberd
Copy link
Contributor

shalberd commented Dec 16, 2022

Agreed that the grayed-out default value of that field or a hover-over popup needs to be more clear on what that field is doing, formats, all that.

I wonder also how you are dealing with importing from the openshift-internal registry, as that requires custom CAs often ... unless you use no verification of trust chain. Same for importing from e.g. a VMWare Harbor or Artifactory Docker Repo. Regarding the naming: I would neither call it repository nor Image Url, but docker image path. On a whole, I have not used this before, just making you aware that importing from a public internet location is not always allowed, that proxy settings HTTP_PROXY and HTTPS_PROXY need to be honored, and that custom CA trust needs to be taken into account. You can get a bundle of all public and additonal CAs from a configmap via auto-injection into the configmap data section https://docs.openshift.com/container-platform/4.10/networking/configuring-a-custom-pki.html#certificate-injection-usin[…]rs_configuring-a-custom-pki

e.g. if I put in https://myartifactory.mycompany.internal.ch/jupyter/image:v0.5, does that download work for servers having a custom CA-based ssl certificate and does it honor HTTP_PROXY and HTTPS_PROXY env variables?

Don't be too focused on the openshift-internal repo and downloads from the public internet, as a general side note. Many customer do not have the internal openshift repo. Many customers also do not have direct Internet access. You'd need to check at least the internal openshift registry for existence either by seeing of pods are in the namespace oc get pods -n openshift-image-registry or oc describe project openshift-image-registry | grep Status or oc describe configs.imageregistry.operator.openshift.io

This functionality is for BYON, isn't it? What happens after the base docker image is downloaded from the public internet? Where is the result stored? In the openshift-internal docker registry at /namespace path? Is an imagestream created based on that openshift-internal docker image in the namespace, too?

@lucferbux lucferbux added good first issue Good for newcomers priority/normal An issue with the product; fix when possible and removed untriaged Indicates the newly create issue has not been triaged yet labels Jan 10, 2023
@andrewballantyne andrewballantyne added the feature/adminui Admin UI Feature label Feb 1, 2023
@manosnoam
Copy link
Contributor

Verified in 2.4:
image

@dgutride dgutride added the stale Issue was created a long time ago and nothing has happened label Dec 8, 2023
@dgutride dgutride added community and removed stale Issue was created a long time ago and nothing has happened labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feature/adminui Admin UI Feature good first issue Good for newcomers kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible
Projects
Status: No status
Status: No status
Status: Dev To do
Development

No branches or pull requests

6 participants