Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does the pull request build? #44

Open
pdurbin opened this issue Jun 15, 2021 · 0 comments
Open

Does the pull request build? #44

pdurbin opened this issue Jun 15, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@pdurbin
Copy link
Contributor

pdurbin commented Jun 15, 2021

Distinct from "ability to preview HTML from pull requests online" (#24) we should have the ability to know ahead of time if a pull request is going to build or not. That is, do all the requirements install? Does make html work?

Currently reviewers of pull requests do these checks manually, which is tedious.

I would think we'd be able to tweak our existing GitHub Actions script added in #9 to run the build on all branches but only push to GitHub Pages if it's the "latest" branch? That is, if the pull request has been merged or if the default branch has been updated directly.

I'm open to other ideas, of course!
@raprasad raprasad added the documentation Improvements or additions to documentation label Jun 16, 2021
@pdurbin pdurbin mentioned this issue Jun 22, 2021
Merged
pdurbin added a commit that referenced this issue Jun 23, 2021
@pdurbin
prevent workflow from running on pull requests #43
25af8a9 
Back when we were using "main" as a branch we made a similar commit at
407b243. Eventually as part of #44 we'll probably add this back in with
some logic about only pushing to the gh-pages branch on merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdurbin @raprasad