Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge openstreetmap/id-tagging-schema and ideditor/schema-builder repos #1294

Open
tordans opened this issue Jul 24, 2024 · 7 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@tordans
Copy link
Collaborator

tordans commented Jul 24, 2024

This came up a few times in conversations, so lets track it as an issue:

I think we should merge the openstreetmap/id-tagging-schema and ideditor/schema-builder repos into one.

Why…

  • Most documentation is in the schema-builder but all usage is here; this makes it hard to search for docs and understand the repo
  • I will be a lot easier for new and recurring users to get into the schema when you can search in browse in one place
  • I don't see any technical advantage into having separate repos

How…
Its quite simple technically speaking. I found those blog post a great help:

@tyrasd tyrasd added the documentation Improvements or additions to documentation label Jul 24, 2024
@k-yle
Copy link
Collaborator

k-yle commented Jul 25, 2024

see also: ideditor/schema-builder#35

@matkoniecz
Copy link
Contributor

Do we know why this repositories were split?

@1ec5
Copy link
Contributor

1ec5 commented Aug 8, 2024

name-suggestion-index also uses schema-builder. Not sure if combining it with id-tagging-schema would make anything harder – or easier.

@bhousel
Copy link
Member

bhousel commented Aug 9, 2024

name-suggestion-index also uses schema-builder.

Are you sure? I don't think it does?

@1ec5
Copy link
Contributor

1ec5 commented Aug 9, 2024

Oh, my bad, it’s actually using id-tagging-schema to generate the presets. All good then. 😅

@tordans
Copy link
Collaborator Author

tordans commented Aug 10, 2024

Another though: We could also use this opportunity to rename the repo to something less iD specific since many editors use the presets here (Rapid, GoMap, SC to some extend AFAIK, MapComplete to some extend AFAIK, …)

Maybe just "tagging-schema"? Or "editor-tagging-schema" to not be too presumptuous.

@matkoniecz
Copy link
Contributor

matkoniecz commented Aug 10, 2024

I think it is fine to say "StreetComplete uses iD presets" (and yes, it does in several places - especially in shops and things overlays and for object descriptions).

Note that describing it as more general will encourage people to ask for changes improving things in say StreetComplete but breaking iD. Now such changes can be easily rejected (or are not asked in the first place)

Also, deprecations like this will create general confusion and will make this specific tagging schema harder to uniquely identify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants