Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunker preset requires a building tag #1321

Open
tohaklim opened this issue Aug 22, 2024 · 0 comments
Open

Bunker preset requires a building tag #1321

tohaklim opened this issue Aug 22, 2024 · 0 comments

Comments

@tohaklim
Copy link

tohaklim commented Aug 22, 2024

The military=bunker preset appears to assume building=bunker now, although I am certain this wasn't the case previously.

I also don't think building=bunker is a required tag on the wiki page, and I can think of a few scenarios (eg underground shelters) where tagging this as a building would seem incorrect or strange (eg on nodes).
This PR from 2014 also suggests building=bunker was the less desirable option.

The validation rule (which I assume is in the iD repo) also suggests adding the building tag back if removing it.

Or is the intended behaviour here to trigger rendering in some sort of scenario that requires a building=* tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant