Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #15

Open
kelson42 opened this issue Aug 17, 2021 · 2 comments
Open

Setup CI #15

kelson42 opened this issue Aug 17, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@kelson42
Copy link
Contributor

  • code factor
  • Minimal automated testing
  • Minimal code coverage
@kelson42 kelson42 added the enhancement New feature or request label Aug 17, 2021
@kelson42 kelson42 added this to the M1 milestone Aug 17, 2021
@rgaudin
Copy link
Member

rgaudin commented Aug 17, 2021

* code factor

AFAIK, there's not much we can do on CI with codefactor. codefactor is subscribed to events on our repo and updates its platform on every commit and PRs (and interacts with PRs of course). It's not actionable in a way we'd expect there.

* Minimal automated testing

We can initiate a small run of the scraper, as we do in sotoki. Will require a dedicated option as no languages is small enough for this task I believe.

* Minimal code coverage

I'd advise against that. We won't have unit tests. If we run that test scrape in a test, it will cover a decent portion of the scraper, thus reporting a relatively high coverage score while none of this code will actually be tested independently. We'd only test the output zim file.

@rgaudin rgaudin modified the milestones: M1, M2 Aug 20, 2021
@rgaudin rgaudin modified the milestones: M2, M3 Aug 31, 2021
@rgaudin rgaudin modified the milestones: M3, M4 Sep 13, 2021
@rgaudin rgaudin removed this from the M4 milestone Oct 1, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants