Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual refresh button #18

Open
thibaultmol opened this issue Jan 22, 2020 · 3 comments
Open

Add manual refresh button #18

thibaultmol opened this issue Jan 22, 2020 · 3 comments

Comments

@thibaultmol
Copy link

Just had the situation where I spotted a new user while going trough osmCha (was done 2 hours ago), but seems like neis already updated because that user also showed up in my rss feed. So being able to manually refresh from neis would be nice (so I could mark that person as having being welcomed)

@jbelien
Copy link
Member

jbelien commented Jan 22, 2020

Hello @thibaultmol
Even though I understand the request, I would not push forward its implementation !
The request towards Pascal Neis API takes quite some time and you would risk to corrupt the files if 2 "update requests" are triggered at the same time (or at least if the 2nd is triggered before the end of the 1st).

@thibaultmol
Copy link
Author

thibaultmol commented Jan 22, 2020

I see, but you couldn't you implement it so that it checks if there is a request in progress, and if so, don't request a new one and just wait on the current one?
EDIT: sorry if I'm glansing over something which would not make that doable

@jbelien
Copy link
Member

jbelien commented Jan 22, 2020

To be honest, the codebase is quite old (and not mine) and I don't really have the time (or the will) to do more than (small) fixes.

It would indeed be a nice feature to add, if anyone is interested to submit a PR, I'll be more than happy to merge it !

@jbelien jbelien added this to the Version 2.0 milestone Jul 17, 2021
@jbelien jbelien mentioned this issue Sep 3, 2021
@jbelien jbelien removed this from the Version 2.0 milestone Oct 30, 2021
@jbelien jbelien added this to the Version 2.3 milestone Sep 1, 2022
@jbelien jbelien modified the milestones: Version 2.3, Version 2.4 Sep 11, 2022
@jbelien jbelien removed this from the Version 2.4 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants