Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Theme Alternative #10

Open
Olaf-007 opened this issue Jul 13, 2024 · 2 comments
Open

Light Theme Alternative #10

Olaf-007 opened this issue Jul 13, 2024 · 2 comments

Comments

@Olaf-007
Copy link

I love this theme and I am using it ever since I discovered it.
However, I am a big fan of switich between light/dark mode during day/night (and there is an upcoming feature called "auto theme switch").
The current theme does not work well when forced with a bright base color.
So here is the suggestion: It would be awesome to have your theme support light colors, too.

@passivestar
Copy link
Owner

Hi!

Godot has very limiting theming capabilities, the default theme only works relatively well in different situations because it's generated in C++. All values that you touch in your own theme become hardcoded (there are no variables or anything like that). This is the reason that to make the theme work for both regular and hidpi displays I need to maintain 2 versions of it, and doing that involves manually editing one of the files. Supporting a light theme would not only mean designing it, but it will also increase the amount of theme files that I need to support to 4

One possible solution to this would be to write a generator with support for variables that will generate the variations automatically. But writing it is additional work in itself, not to mention that it will make it harder to work on the theme in the editor

Given how limiting godot theming is I believe it is better to improve theming on the engine side first. When there's support for variables and partial styleboxes in godot themes maybe I'll consider the light theme

@Olaf-007
Copy link
Author

That sounds reasonable. I will continue using your dark theme then, it really pulls me into the engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants