Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Draw Extra Borders" does not work #11

Open
Racer911dash1 opened this issue Aug 18, 2024 · 3 comments
Open

"Draw Extra Borders" does not work #11

Racer911dash1 opened this issue Aug 18, 2024 · 3 comments

Comments

@Racer911dash1
Copy link

I've been setting up the theme as instructed, however I noticed that the "Draw Extra Borders" Option does not function at all. Nothing changes when it gets toggled on or off.
It is kind of a problem as it especially affects the File system window (Attached Image).
image
image

@passivestar
Copy link
Owner

passivestar commented Aug 18, 2024

Those panels not having any visual separation is not a border problem, it's a limitation of godot editor theming where all trees and item lists share the same styleboxes. So some lists not having visual boundaries where they appear to be needing them is a compromise I had to make to make the main window docks look as they do. It wasn't possible to fix in Godot 4.3. Hopefully 4.4 will be different

"Draw Extra Borders" shouldn't exist in the first place, Godot already has excessive borders by default, as far as accessibility goes I'd rather improve the visibility of UI elements by increasing contrast rather than drawing extra lines

@Racer911dash1
Copy link
Author

Oh okay, so is there an alternative solution? Or will I have to decide between a mild inconvenience or switching back to the default godot theme?

@passivestar
Copy link
Owner

No solution yet. It's a work in progress and there are more things that are broken because they are simply unthemable. I fixed what I could for the release of 4.3 on the engine side, but there's still a lot of work to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants