Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for not dotted package, how to create a egg from plonecli #542

Open
yurj opened this issue Jan 26, 2023 · 0 comments
Open

support for not dotted package, how to create a egg from plonecli #542

yurj opened this issue Jan 26, 2023 · 0 comments

Comments

@yurj
Copy link
Contributor

yurj commented Jan 26, 2023

configurator.variables["package.namespace"] = configurator.variables[
"package.dottedname"
].split(".")[0]

Hi!
what about packages like
mypackage/src/namespace/name ?

Actually it is supported only

namespace.name/src/namespace/name

Can we just use setup.py to find namespace and name? Or it is better to avoid this kind of situation, just renaming mypackage in namespace.name?

How to improve?

With plonecli I've created an addon with a dotted namespace but I copied all the directory (the one with buildout inside) in plone src/mypackage instead of copying just the plonecli created subfolder src/namespace in src/namespace.name/ in plone. It works because how setup.py is created to make possible to have buildout in the same directory (base.cfg -> develop = .). Is this the way to do it?

If I want to create an egg from the plonecli addon, I've to move that code around, change the lines in setup.py:

    packages=find_packages('src', exclude=['ez_setup']),
    package_dir={'': 'src'},

So I think the template should create a src/namespace.name/namespace/name and use develop = src/namespace.name/ (or better mr.developer?), moving setup.py in src/namespace.name (removing the lines above about packages). Could this help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant