Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters doubly escaped if Hotfix20200121 is present in 5.2.2 #246

Open
ewohnlich opened this issue Jan 11, 2021 · 1 comment
Open

Characters doubly escaped if Hotfix20200121 is present in 5.2.2 #246

ewohnlich opened this issue Jan 11, 2021 · 1 comment

Comments

@ewohnlich
Copy link

This hotfix is no longer needed if upgrading to 5.2.2 but I believe the goal is for this to simply have no effect if added anyway. This is not true for the following case, where dict editing causes characters to be doubly escaped if this hotfix is present in 5.2.2.

To Reproduce:
Plone 5.2.2, with PloneHotfix20200121 present. Create a folder with title "A&W" or some other escapable character, with automated tabs turned on. The tab will incorrectly render as "A&W" (source code will be "A&W") because both the hotfix and the default render_item code attempt to escape characters.

The non-hotfix code is in plone.app.layout.viewlets.common.GlobalSectionsViewlet. Perhaps this can be updated to check if the Hotfix is installed, and only escape the name/title if it is not? I'm assuming we don't want to try to fix the Hotfix itself.

@mauritsvanrees
Copy link
Sponsor Member

It would be nice if the hotfix would not do anything if it is not needed, but for a lot of patches this will not possible. At least not for a patch that calls the original method, and then does something extra.

The only thing I can imagine is adding code in Products.CMFPlone that logs a warning on startup if a hotfix is installed which we know is no longer needed.

I do know that I myself sometimes fall into this trap of updating a site to a newer Plone version and forgetting to remove hotfixes.

talarias pushed a commit that referenced this issue Dec 9, 2021
…-portal-messages

Revert "Added a border animation to the alert boxes"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants