Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDF files to uploadable media types (including commentaries) #26

Open
Ironman28 opened this issue Jul 15, 2015 · 6 comments
Open

Add PDF files to uploadable media types (including commentaries) #26

Ironman28 opened this issue Jul 15, 2015 · 6 comments

Comments

@Ironman28
Copy link

Would it be possible for Critical Commons to handle PDF files? I am asked about this regularly by people who are using CC to embed media into Scalar. How hard would it be to implement?

@ahelme ahelme added this to the spring 2015 - normal priority milestone Oct 13, 2015
@ahelme
Copy link
Member

ahelme commented Oct 13, 2015

Steve - I just added a PDF to my folder, by visiting my folder
http://www.criticalcommons.org/Members/anna/

choosing Add New > File from the green bar.

http://www.criticalcommons.org/Members/anna/test-pdf/view

Is this sufficient? I don't remember exactly how Scalar uses files, and if Scalar can access files such as the one I just added above...

@Ironman28
Copy link
Author

I have confirmed with the Scalar team that this system will NOT work for importing PDFs into Scalar. For this to work, a PDF would have to be able to be uploaded and displayed the same way we currently handle images - including the need for a critical commentary before it was visible. If this is too difficult, please leave it for a later development cycle. If it is not too difficult, this is a feature that is often asked for!

@ahelme ahelme changed the title Allow PDF files to be uploaded? Add PDF files to allowed Image file types (if that works) Oct 15, 2015
@ahelme
Copy link
Member

ahelme commented Oct 15, 2015

Hmm, I'm a bit confused, how does a user currently add an image?

Surely not by clicking Upload, like a video?

@ahelme ahelme changed the title Add PDF files to allowed Image file types (if that works) Add PDF files to uploadable media types (including commentaries) Oct 15, 2015
@Ironman28
Copy link
Author

Yes, it works just like uploading a video. UnWeb added that functionality a couple of years ago. You can also upload audio that way.

@ahelme
Copy link
Member

ahelme commented Oct 20, 2015

Ah, I'd forgotten that! Hmm, it sounds like also perhaps some UI work could be done to make that more apparent to the user - as it simply refers to "videos" and "clips" and what not?

For now, I guess it's a matter of adding the file type BUT I'm not sure if that might have any other implications?

@Ironman28
Copy link
Author

Ugh. Yes, I decided not to comb through the site looking for instances that say "video" or "clip" -- that is for the future. But for now, if it's possible for PDFs to simply function (and embed?) like images, that would be great. If not, we will survive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants