Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component style issues #16485

Open
kszmetena opened this issue Oct 3, 2024 · 1 comment
Open

Select component style issues #16485

kszmetena opened this issue Oct 3, 2024 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@kszmetena
Copy link

kszmetena commented Oct 3, 2024

Describe the bug

I just started to use the new primeng v.18 and bumped into the following style issues at select component.

  1. In the invalid style of Select component has a reference to css var of SelectButton component. As I noticed every css var of component created dynamically when a component created, so if you don't have SelectButton component your app, the referenced css var is not created and the invalid style is broken of your Select component.

  2. When I use with float label the label is not floating out when an item is selected and the focus is outside of select. The p-inputwrapper-filled class is not added to select when it's filled. I chekced and the bool expression is wrong in style ts file.

Environment

It doesn't matter :)

Reproducer

No response

Angular version

18.2.6

PrimeNG version

18.0.0-beta.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.3.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Add the Select component to your app without using of SelectButton component
  2. Use the Select component with float label and select an item and click outside of select.

Expected behavior

  1. The style of invalid select component shouldn't have to rely on SelectButton css var.
  2. The proper bool expression: 'p-inputwrapper-filled': instance.modelValue() !== undefined && instance.modelValue() !== null && !!instance.modelValue().length,
@kszmetena kszmetena added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 3, 2024
@kszmetena kszmetena changed the title Select component invalid style issue Select component style issues Oct 3, 2024
@laszlokovari
Copy link

I have the same issue with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants