Problems related to TestDownloadCustomTemplatesFromGitHub test

[xm1k3]

Nuclei version:

2.8.9

Current Behavior:

branch: dev

--- FAIL: TestDownloadCustomTemplatesFromGitHub (10.01s)
    github_test.go:31: 
        	Error Trace:	/home/runner/work/nuclei/nuclei/v2/pkg/external/customtemplates/github_test.go:31
        	Error:      	unable to find file "/tmp/template-custom-935556463/github/nuclei-templates-ehsandeep"
        	Test:       	TestDownloadCustomTemplatesFromGitHub
        	Messages:   	cloned directory does not exists

Expected Behavior:

Success test

Steps To Reproduce:

go test ./...

Anything else:

more info also here: https://github.com/projectdiscovery/nuclei/actions/runs/4223199715/jobs/7332787046

[tarunKoyalwar]

@xm1k3 , closing this since this was fixed . above unit tests downloads template from ehsandeep/nuclei-templates which was accidently deleted and it is now restored

[xm1k3]

@tarunKoyalwar I figured that was the problem as it returned 404, I had spoken to @Mzack9999 if for future purposes we could make it more dynamic, maybe a repo under pd org, but if it is restored it's ok

[ehsandeep]

This test started to fail again on windows even https://github.com/ehsandeep/nuclei-templates does exist.

--- FAIL: TestDownloadCustomTemplatesFromGitHub (42.52s)
    github_test.go:34: 
        	Error Trace:	D:/a/nuclei/nuclei/v2/pkg/external/customtemplates/github_test.go:34
        	Error:      	unable to find file "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\template-custom-13578[49](https://github.com/projectdiscovery/nuclei/actions/runs/5504540247/jobs/10030852874?pr=3916#step:6:50)[51](https://github.com/projectdiscovery/nuclei/actions/runs/5504540247/jobs/10030852874?pr=3916#step:6:52)2\\github\\nuclei-templates-ehsandeep"
        	Test:       	TestDownloadCustomTemplatesFromGitHub
        	Messages:   	cloned directory does not exists

[tarunKoyalwar]

@ehsandeep , i was just looking into it. i am not able reproduce it in mac the issue only seems to be in windows tests

[Mzack9999]

@ehsandeep, please delete and recreate your nuclei-templates fork. There is an extra space in one of the templates paths which are not compatible with Windows, causing the test to fail: