Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component names printable ASCII only? #47

Closed
bilderbuchi opened this issue Feb 14, 2023 · 1 comment · Fixed by #38
Closed

Component names printable ASCII only? #47

bilderbuchi opened this issue Feb 14, 2023 · 1 comment · Fixed by #38

Comments

@bilderbuchi
Copy link
Member

In #38, we decided that

A Component name must be a series of ASCII characters, without the character "."

Originally posted by @bilderbuchi in #38 (comment)

To avoid shenanigans with escape sequences or whatnot, I would prefer to restrict this to the printable ASCII range except ., i.e. 0x20 to 0x7E, excluding 0x2E.

Thoughts?

@BenediktBurger
Copy link
Member

I'm fine with it.

I don't see any good reason, why someone could neet a carriage return or new line etc as a Charakter in a name.

@BenediktBurger BenediktBurger linked a pull request Feb 16, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants