Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/logback 1701 newrule is ignored #681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jaam
Copy link

@jaam jaam commented Jun 22, 2023

Hello, we are upgrading our product to Spring Boot 3.1.0 (which uses logback 1.4.7) and then we noticed that configurations in logback-spring.xml were being ignored.

After some debugging I noticed the code is commented out (SimpleRuleStore.java#87) and after searching in JIRA, I saw it has been reported already (https://jira.qos.ch/browse/LOGBACK-1701) and closed. Our use case is simple, with the newRule we reference the AppenderRefAction in a custom Appender to be able to delegate to a second appender under certain conditions.

This pull request just takes out the commented code and provides a simple fix. If the PR is declined, is there an alternative to it? This would potentially block our ongoing migration until an alternative solution is found.

By the way, the documentation still refers to this configuration option: https://logback.qos.ch/manual/onJoran.html#newRule.

Best regards and thank you for your time,
José

jaam added 2 commits June 22, 2023 16:40
Signed-off-by: Jose Antonio Alvarez <[email protected]>
@jaam jaam force-pushed the bugfix/LOGBACK-1701-newrule-is-ignored branch from dc9415d to 36cda65 Compare June 22, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant