Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cuVS should copy its clang-format from other RAPIDS libs #307

Open
harrism opened this issue Aug 29, 2024 · 0 comments
Open

[BUG] cuVS should copy its clang-format from other RAPIDS libs #307

harrism opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@harrism
Copy link
Member

harrism commented Aug 29, 2024

Describe the bug
cuVS .clang-format does not include the header ordering code that was added for all other RAPIDS C++ libraries. E.g. from RAFT:

IncludeCategories:
  - Regex:           '^"' # quoted includes
    Priority:        1
  - Regex:           '^<(common|benchmarks|tests)/' # benchmark/test includes
    Priority:        2
  #- Regex:           '^<(cuspatial_test|cuproj_test)/' # cuSpatial/cuProj test includes
  #  Priority:        3
  - Regex:           '^<raft/' # RAFT includes
    Priority:        3
  - Regex:           '^<(cudf|cuml|raft|kvikio)' # Other RAPIDS includes
    Priority:        4
  - Regex:           '^<rmm/' # RMM includes
    Priority:        5
  - Regex:           '^<(thrust|cub|cuda)/' # CCCL includes
    Priority:        6
  - Regex:           '^<(cooperative_groups|cuco|cuda|device_types|driver_types|math_constants|nvtx3)' # CUDA includes
    Priority:        6
  - Regex:           '^<.*\..*' # other system includes (e.g. with a '.')
    Priority:        7
  - Regex:           '^<[^.]+' # STL includes (no '.')
    Priority:        8

As a result, header ordering is not consistent and not automatically formatted.

Expected behavior
Start from the clang-format of existing RMM libraries.

@harrism harrism added the bug Something isn't working label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant