Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built Docker image is always using vcs.sha label with an unspecified value #347

Open
fredmaggiowski opened this issue May 28, 2024 · 0 comments · May be fixed by #348
Open

Built Docker image is always using vcs.sha label with an unspecified value #347

fredmaggiowski opened this issue May 28, 2024 · 0 comments · May be fixed by #348
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers

Comments

@fredmaggiowski
Copy link
Member

Describe the bug

If I inspect the built docker image it features the vcs.sha always set to

~ docker inspect ghcr.io/rond-authz/rond | grep "vcs.sha" -B 3
        "org.opencontainers.image.url": "https://github.com/rond-authz/rond",
        "org.opencontainers.image.vendor": "rond authz",
        "org.opencontainers.image.version": "1.12.4",
        "vcs.sha": "<not-specified>"

This happens because the Dockerfile expects the value to be set from the COMMIT_SHA environment variable but the build job is never setting it.

Expected behavior

The label to properly set

Replication info

  • Rönd version: any
  • run: docker inspect ghcr.io/rond-authz/rond | grep "vcs.sha"
@fredmaggiowski fredmaggiowski added needs triage bug Something isn't working github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers and removed needs triage labels May 28, 2024
@malta895 malta895 linked a pull request May 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant