Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for RInterface::Take isn't clear about column parameter #16487

Open
Axel-Naumann opened this issue Sep 20, 2024 · 1 comment
Open

Doc for RInterface::Take isn't clear about column parameter #16487

Axel-Naumann opened this issue Sep 20, 2024 · 1 comment

Comments

@Axel-Naumann
Copy link
Member

Explain what you would like to see improved and how.

https://root.cern/doc/master/classROOT_1_1RDF_1_1RInterface.html#aa571f08b8e4d9300cacdea039a379a22

column has a default value, but the doc doesn't say what it will do if I don't pass a value. Is that totally obvious and I'm just missing this, or is it documented elsewhere?

ROOT version

master

Installation method

n/a

Operating system

n/a

Additional context

No response

@martamaja10
Copy link
Contributor

Hi @Axel-Naumann, this is not directly documented at action Take but there is an explanation what happens when you use DefaultColumns here: https://root.cern/doc/master/classROOT_1_1RDataFrame.html#default-branches . With Take, it will be analogous to the Histo1D() or Min() shown in the example code. So Take<T>("") will act on the first of the default columns (you will have to correctly specify the template though, otherwise you'll get an error). I can extend the example to show Take as well, would that be a satisfactory solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants