Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor document parsing #113

Open
elinw opened this issue Jun 18, 2019 · 1 comment
Open

Refactor document parsing #113

elinw opened this issue Jun 18, 2019 · 1 comment

Comments

@elinw
Copy link
Collaborator

elinw commented Jun 18, 2019

Parsing of the documents has now been pulled out to a separate function, parse_one_document(). However there are still many levels of loops which are not the ideal approach for many situations in R. The code is also very complex.

What should happen is to simplify this code through a combination of creating some separate functions and by using lapply() and its relatives when appropriate.

@elinw
Copy link
Collaborator Author

elinw commented Jun 29, 2019

This has been started but it is still a very long and complex function that is hard to read, so we should work on improving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant