Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: support for VIRTIO_F_IN_ORDER and Packed Ring #241

Open
aftersnow opened this issue May 12, 2023 · 4 comments
Open

FR: support for VIRTIO_F_IN_ORDER and Packed Ring #241

aftersnow opened this issue May 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@aftersnow
Copy link

These two features are benefits to performance

@stsquad stsquad added the enhancement New feature or request label May 15, 2023
@stsquad stsquad changed the title Looking forward for supporting VIRTIO_F_IN_ORDER and Packed Ring FR: support for VIRTIO_F_IN_ORDER and Packed Ring May 15, 2023
@rbradford
Copy link
Contributor

I don't think this crate needs to care about VIRTIO_F_IN_ORDER - that's more for the VMM to do it.

@aftersnow
Copy link
Author

I don't think this crate needs to care about VIRTIO_F_IN_ORDER - that's more for the VMM to do it.

Yes, thanks for reply. The "Packed Ring" should benefits for performance, do you have plan to add support for it?

@uran0sH
Copy link
Contributor

uran0sH commented Aug 20, 2024

I will work on adding support for packed vring if no one works on it.

@stefano-garzarella
Copy link
Member

@uran0sH that would be nice! If it can help, we implemented packed virtqueues in libblkio, but we didn't use rust-vmm crates in that project. You can find the code here: https://gitlab.com/libblkio/libblkio/-/blob/main/virtio-driver/src/virtqueue/packed.rs?ref_type=heads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants