Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor formula to match template-formula #22

Open
alxwr opened this issue Jun 14, 2019 · 3 comments
Open

Refactor formula to match template-formula #22

alxwr opened this issue Jun 14, 2019 · 3 comments
Assignees

Comments

@alxwr
Copy link
Member

alxwr commented Jun 14, 2019

  • use defaults.yaml & Co.
  • reduce Pillar data
    i.e. this needs to go:
dnsmasq:
  dnsmasq_conf: salt://dnsmasq/files/dnsmasq.conf
  dnsmasq_hosts: salt://dnsmasq/files/dnsmasq.hosts
  dnsmasq_cnames: salt://dnsmasq/files/dnsmasq.cnames
  dnsmasq_conf_dir: salt://dnsmasq/files/dnsmasq.d
@alxwr alxwr self-assigned this Jun 14, 2019
@alxwr
Copy link
Member Author

alxwr commented Jun 14, 2019

@myii @aboe76 Please add suggestions if you have any.

@myii
Copy link
Member

myii commented Jun 18, 2019

@alxwr Thanks for this. A few more, some stating the obvious:

  • Update map.jinja.
  • Change {%- ... -%} => {%- ... %} (ref).
  • Use TOFS for all file handling.

@daks
Copy link
Member

daks commented Mar 9, 2022

I agree that this formula needs some work, @alxwr quotes some pillar which appears useless to me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants