Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 support #643

Closed
3 tasks done
Zethson opened this issue Aug 20, 2024 · 3 comments
Closed
3 tasks done

Python 3.12 support #643

Zethson opened this issue Aug 20, 2024 · 3 comments
Assignees
@Lilly-May
Labels
enhancement New feature or request

Comments

@Zethson
Copy link
Member

Zethson commented Aug 20, 2024 •
edited by Lilly-May
Loading

Description of feature

  • Check whether tests and use-cases run with Python 3.12. It might be annoying to rerun all tutorials so let's primarily keep it to the tests + maybe the paper use-cases?
  • Replace Python 3.11 in the CI with 3.12
  • Add it in the pyproject.toml
@Zethson Zethson added the enhancement New feature or request label Aug 20, 2024
@Lilly-May
Copy link
Collaborator

Sounds good! I'm on it.

@Lilly-May Lilly-May mentioned this issue Aug 20, 2024
Merged
1 task
@Lilly-May
Copy link
Collaborator

ToDos 2 and 3 are addressed in PR #644. I'll verify that the use cases work with Python 3.12 while converting the use-case notebooks into tutorials for the docs (see #642), so I'll keep this issue open for now.

@Lilly-May
Copy link
Collaborator

I ran the paper use-cases with Python 3.12 and created scverse/pertpy-tutorials#48. Hence, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilly-May Lilly-May

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zethson @Lilly-May