Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect parsing of Windows drive letter quirk (#889) #890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GabrielDertoni
Copy link

  • Fixes the parser to correctly parse "file:///C|/hello/world" into "file:///C:/hello/world"

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92f356e) 81.70% compared to head (7dda791) 81.66%.

❗ Current head 7dda791 differs from pull request most recent head 19ebc6c. Consider uploading reports for the commit 19ebc6c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   81.70%   81.66%   -0.04%     
==========================================
  Files          20       20              
  Lines        3547     3545       -2     
==========================================
- Hits         2898     2895       -3     
- Misses        649      650       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Fixes the parser to correctly parse "file:///C|/hello/world" into "file:///C:/hello/world"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant