Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete ShipwrightBuild object if operator was removed #70

Open
adambkaplan opened this issue Apr 28, 2022 · 3 comments
Open

Cannot delete ShipwrightBuild object if operator was removed #70

adambkaplan opened this issue Apr 28, 2022 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@adambkaplan
Copy link
Member

Expected Behavior

If the Shipwright operator is removed, any ShipwrightBuild object should also be removed.

Actual Behavior

ShipwrightBuild objects remain (along with their related deployment of the Build controller). ShipwrightBuild objects cannot be deleted due to the finalizer placed on the ShipwrightBuild object.

Operator Version

v0.9.0

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 28, 2022
@qu1queee qu1queee added this to the release-v0.10.0 milestone May 4, 2022
@qu1queee
Copy link

qu1queee commented May 4, 2022

From grooming: @adambkaplan what would be the difference of this issue and #71 ?

@adambkaplan
Copy link
Member Author

@qu1queee this is a separate issue that occurs because the Shipwright operator adds a finalizer to the ShipwrightBuild object. If the operator is removed after a ShipwrightBuild object had been created, the ShipwrightBuild object may never get deleted from the cluster.

@SaschaSchwarze0
Copy link
Member

From grooming: the finalizer problem is a common problem with controllers in Kubernetes that get removed but objects with owned finalizers still exist. Documentation might be the only way to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants