Right to left issues #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
April 14, 2023 10:15
…r of times the warning msg pops up)... but only when the user attempts to write it (so a person who just wants to see the translation and doesn't try to write it (Next or SaveChanges buttons) doesn't get bothered
… as "True" and failed the compare w/ 'true'
…ens (e.g. COL 4:1, which is at the end of chp 3 (as a \vp 4:1\va*) rather than in chapter 4, where it doesn't exist)
…ily override the source project (in the form, rather than in the IParatextStandalonePlugin implementing class)
…(so the form it's in can add its own handlers). Also, added two menu item to the Paratext BTH Form to combine text in a paragraph to improve the translation of text (think: postpose any inline markers) AND a menu item to choose a new source project. Also, added settings to save the state of those menu items.
…cludes only the main text and inline markers and text fragments are postposed and translated separately (so they don't interrupt the translation of the main text). Also, set up a preview of the translated text and what markers go with it, so that it's easier to see if what you have will match with the source markers.
…of the status bar when the user makes changes to the translation (AND provide a tooltip preview so they can see which lines of translated text will go in which paratext markers) to be an asynchronous task, which isn't as flakey in posting the results as the previous implementation was.
…arker also (the quoted text of a footnote)
… rather, moving inline markers w/ text to the end), treat the \q1-4 markers special, so their text segments get combined even though they're in different paragraphs (leads to better translation).
p.s. this has a undesirable behavior that I haven't figured out how to work-around yet: if a \q1 paragraph marker is immediately followed by a \v marker, then technically, the \q1 is in the preceding verse reference; not this one, so though we'd want to say that we're 'processingQs' in this case, we can't, so the text on that line will be translated separately from the \q2, etc., that follows it. UPDATE: I've made the _processingQs bool a global variable, so that if one verse ends w/ a \q{digit} paragraph marker and the next verse starts with one (and the user does the 'next' verse after the previous one), then we will correctly interpret the post \v text as _processingQs = true.
…pdate, so it'll update or add as needed (rather than checking if the key is already in the dictionary) -- don't know how/why, but I got a 'key already present' exception when doing it the "check first and then 'Add'" way...
…cking around in Ptx in different verses, and the user clicks the 'click here' status line to go ahead and update to the current verse, then change it so that it'll refresh the edit box either if we're on some other verse (meaning they didn't want their edits anymore) or if it's the same verse, then ask them if they want to update to the current target verse or keep the edits.
…Fixer mode (where left click means add the clipboard text as a FindWhat for a replacement/substitution) then left click means repeat the last conversion (i.e. use the same converter as chosen last time for the clipboard text.
…nd we're on the same verse we pause updates on, and the user says they want to keep the edited text, then don't reset the ismodified flag or the edited text (which they obviously want to keep) can be overwritten if they continue to poke around in other verses in Ptx.
… left-click means add a Spellfixer substitution)
… back translation helper). And prevent a problem that can cause the form to shrink to minimum size and reappear that way on the next launch.
…e text postposing the inline markers
…w/ the "Clear" Paratext Plugin from Biblica trying to use the file, Microsoft.Extensions.DependencyInjection.Abstractions, which SILConverters installed, but failing because it's a lower version number... don't ask why it should be trying to use a dll in an unrelated product...) and updated the corresponding bindingRedirect statements
… the user doesn't have edit privileges (it wouldn't write anyway, but at least then it won't seem like it should) and changed the way we pass that information to the Initialize method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Add Substitute dialog wasn't displaying RTL languages properly. These commits fix that.