Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript_sdk_url shipping_preference parameter breaks the PayPal integration #149

Open
RyanofWoods opened this issue Dec 16, 2021 · 1 comment
Labels

Comments

@RyanofWoods
Copy link
Contributor

When any of the 3 pages (cart, product and payment) pages go to create the PayPal SDK URL, it will attempt to add the shipping_preference param if the delivery step is not present. However, it seems that PayPal does not accept this parameter, as the request returns a 400 (bad request) and then the integration breaks. (when the param is removed it works as normal.)

https://github.com/solidusio-contrib/solidus_paypal_commerce_platform/blob/19c00c68220fa9b7490dcc6497030809cbbfda03/app/models/solidus_paypal_commerce_platform/payment_method.rb#L77
Screenshot 2021-12-16 at 19 49 31

This parameter is not listed in their current documentation:
https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#query-parameters

The only reference I see to it, is here:
https://developer.paypal.com/docs/api/payments/v1/?mark=shipping_preference%20

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant