From 59c20107df165fe822f4d1a4548a7b2e1d624a7a Mon Sep 17 00:00:00 2001 From: David Jumani Date: Mon, 26 Jun 2023 12:12:16 -0400 Subject: [PATCH] use optional desscription instead of comments to describe tests --- projects/gloo/pkg/xds/cache_test.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/projects/gloo/pkg/xds/cache_test.go b/projects/gloo/pkg/xds/cache_test.go index 18fff3b6d61..0c7e79cd7ae 100644 --- a/projects/gloo/pkg/xds/cache_test.go +++ b/projects/gloo/pkg/xds/cache_test.go @@ -16,8 +16,8 @@ var _ = Describe("Cache", func() { It("NodeRoleHasher generates the correct ID", func() { nodeRoleHasher := xds.NewNodeRoleHasher() node := &envoy_config_core_v3.Node{} - // Ensure it returns the fallback key if the role field in the node metadata is not present - Expect(nodeRoleHasher.ID(node)).To(Equal(xds.FallbackNodeCacheKey)) + Expect(nodeRoleHasher.ID(node)).To(Equal(xds.FallbackNodeCacheKey), + fmt.Sprintf("Should return %s if the role field in the node metadata is not present", xds.FallbackNodeCacheKey)) role := "role" node.Metadata = &structpb.Struct{ @@ -25,8 +25,7 @@ var _ = Describe("Cache", func() { role: structpb.NewStringValue(role), }, } - // Ensure it returns the role field in the node metadata - Expect(nodeRoleHasher.ID(node)).To(Equal(role)) + Expect(nodeRoleHasher.ID(node)).To(Equal(role), "Should return the role field in the node metadata") }) It("SnapshotCacheKeys returns the keys formatted correctly", func() {