Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changes in envoy 1.31 upgrade #10146

Open
andy-fong opened this issue Oct 2, 2024 · 0 comments
Open

Document changes in envoy 1.31 upgrade #10146

andy-fong opened this issue Oct 2, 2024 · 0 comments

Comments

@andy-fong
Copy link
Contributor

Version

main (1.18.x beta)

Gateway API

Gloo Edge API

Describe the requested changes

Removed config setting:

We mentioned using “envoy.reloadable_features.token_passed_entirely in docs/content/operations/upgrading/faq.md when gloo 1.17 upgraded to 1.29 from 1.27 envoy. This runtime flag is removed and can no longer be turned off. So, need to remove that for our doc and probably call this out in the upgrade FAQ

jwt_authn change:

jwt_authn: jwt_authn now validates provider URIs. If the validation is too strict it can temporarily be disabled by setting the runtime guard envoy.reloadable_features.jwt_authn_validate_uri to false. 

This might impact customers if their provider URI is not strictly following the RFC. Here is some common issue that might work before but will not longer work (envoy would not start):
Common Validation Failure with this release:

  • hostname contains _ (underscore character)
  • url contains non-English characters (ASCII code > 127)
  • url contains unencoded (space character)
  • url contains TAB (ASCII code 9) or FormFeed (ASCII code 12) characters

The parser code used to validate the URL is here. The compile time flag HTTP_PARSER_STRICT is on by default and we have not disabled it.

Other changes:
Other changes are minor and might just need to be called out in the change log but the full list can be found in this doc under Action Items -> ChangeLog Callouts

Link to any relevant existing docs

https://docs.solo.io/gloo-edge/latest/operations/upgrading/faq/#breaking-changes

Browser Information

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant