Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add default configurations for upstreams discovered from Consul #8437

Open
jasonz3157 opened this issue Jul 4, 2023 · 1 comment
Open
Labels
stale Issues that are stale. These will not be prioritized without further engagement on the issue. Type: Enhancement New feature or request

Comments

@jasonz3157
Copy link

jasonz3157 commented Jul 4, 2023

Version

1.14.8

Is your feature request related to a problem? Please describe.

metadata:
  name: default
  namespace: gloo-system
gloo:
  xdsBindAddr: 0.0.0.0:9977
consul:
  httpAddress: consul-svc.default.svc.cluster.local:8500
  serviceDiscovery: {}
consulKvSource: {}
discoveryNamespace: gloo-system
refreshRate: 5s

When I enable automatic discovery of Consul services and Consul key-value storage, Gloo will create a new upstream in Consul's gloo/gloo.solo.io/v1/Upstream/gloo-system/, like:

If I want to configure slow_start, I need to add these configurations manually :

But if the Consul service was deregistered, all these configurations in kv will also be deleted.

After the service reappears, the upstream goes back to the initial state without my slow_start configurations.

Describe the solution you'd like

So is there a configuration to add some default configurations for auto-discovered upstreams?

I tried Global annotations for upstreams, but it doesn't seem to be working.

...
consul:
  httpAddress: consul-svc.default.svc.cluster.local:8500
  serviceDiscovery: {}
consulKvSource: {}
upstreamOptions:
  globalAnnotations:
    gloo.solo.io/upstream_config: '{"loadBalancerConfig":{"roundRobin":{"slowStartConfig":{"slowStartWindow":"60s"}}}}'

Describe alternatives you've considered

No response

Additional Context

No response

@jasonz3157 jasonz3157 added the Type: Enhancement New feature or request label Jul 4, 2023
Copy link

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

@github-actions github-actions bot added the stale Issues that are stale. These will not be prioritized without further engagement on the issue. label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that are stale. These will not be prioritized without further engagement on the issue. Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant