Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emicorr memory and run time improvement #8848

Open
stscijgbot-jp opened this issue Oct 1, 2024 · 0 comments
Open

emicorr memory and run time improvement #8848

stscijgbot-jp opened this issue Oct 1, 2024 · 0 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3770 was created on JIRA by Maria Pena-Guerrero:

While working on optimizing Detector1 memory usage and runtime, I found that this small change made a big improvement for the performance of the emicorr step:

emicorr.py script, staring at line 441

 

# Safety catch; anywhere the noise value is not finite, set it to zero 
dd_noise[~np.isfinite(dd_noise)] = 0.0

# Subtract EMI noise from the input data        
log.info('Subtracting EMI noise from data')

 # Interleave (straight copy) into 4 amps        
noise_x = np.arange(nx4) * 4        
for k in range(4):            
    output_model.data[..., noise_x + k] = output_model.data[..., noise_x + k] - dd_noise

then add the dd_noise array to the deletion statements

 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant