feat(sql): add configuration property sql.healthIntervalMillis #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that controls how often the health endpoint refreshes information when using sql. It defaults to 30 seconds to match the behavior before this change. Information about cache status for each object type (e.g. pipelines, applications, etc.) contributes to the response from front50's /health endpoint. This change makes it possible to reduce the likelihood that the cache has refreshed, but the response from the /health endpoint doesn't reflect that.
jvz
reviewed
Jun 30, 2023
| /** | ||
| * How frequently to refresh health information (e.g. for the health endpoint). | ||
| */ | ||
| var healthIntervalMillis: Long = Duration.ofSeconds(30).toMillis() |
There was a problem hiding this comment.
Nit: this could be a Duration and converted to other duration units on demand.
There was a problem hiding this comment.
Yeah. I still need to wrap my head around what that means for variable names and how config files look to do it that way.
jvz
approved these changes
Jun 30, 2023
dbyron-sf
added a commit
to dbyron-sf/spinnaker.io
that referenced
this pull request
Jun 30, 2023
dbyron-sf
added a commit
to spinnaker/spinnaker.io
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that controls how often the health endpoint refreshes information when using sql. It defaults to 30 seconds to match the behavior before this change.
Information about cache status for each object type (e.g. pipelines, applications, etc.) contributes to the response from front50's /health endpoint. This change makes it possible to reduce the likelihood that the cache has refreshed, but the response from the /health endpoint doesn't reflect that.