chore(dependency): fix to upgrade groovy 3.x #1391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile upgrading to groovy 3.x While upgrading groovy from 2.5.15 to 3.0.10, encountered following error during front50-web:test : ``` startup failed: /front50/front50-web/src/test/groovy/com/netflix/spinnaker/front50/controllers/PipelineControllerTck.groovy: 42: unable to resolve class groovy.json.JsonSlurper @ line 42, column 1. import groovy.json.JsonSlurper ^ 1 error FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':front50-web:compileTestGroovy'. ``` To resolve this issue added testImplementation of org.codehaus.groovy:groovy-json in front50-web.gradle
…jupiter-engine with upgrade of groovy 3.x
j-sandy
changed the title
|
Closing this PR and going to raise 2 separate PRs for given 2 commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(dependency): add testImplementation of groovy-json dependency while upgrading to groovy 3.x
While upgrading groovy from 2.5.15 to 3.0.10, encountered following error during front50-web:test :
To resolve this issue added testImplementation of org.codehaus.groovy:groovy-json in front50-web.gradle
refactor(build): cleanup of junit-vintage-engine and introduce junit-jupiter-engine with upgrade of groovy 3.x