Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw out readKeys for a group when we're excluded #103

Open
Powersource opened this issue Apr 26, 2023 · 1 comment
Open

Throw out readKeys for a group when we're excluded #103

Powersource opened this issue Apr 26, 2023 · 1 comment

Comments

@Powersource
Copy link
Collaborator

Powersource commented Apr 26, 2023

We've been doing that but in #101 (comment) we discovered that that breaks some index/db2 code, so now I'm gonna change it so we just keep readKeys for a group we're excluded from.

Since the readKeys are sent to us in public (in that they're on non-hidden feeds) messages encrypted as DMs to us, it's trivial to find the readKeys again. So this isn't super high priority. But there's no reason to keep them in storage, so we should throw the keys out.

This is a separate issue from #102. That issue is about deleting the group feeds from the group. But there are group related messages that are not on the group feeds, such as the group feed announce messages, and the member addition messages on the additions feeds. #102 should be done before this issue, since it's both simpler and has a bigger impact.

@Powersource
Copy link
Collaborator Author

The PRs where we start keeping the readKeys (and root) https://gitlab.com/ahau/lib/ssb-keyring/-/merge_requests/26 and ssbc/ssb-box2#32

I think this issue would involve basically reverting those. As well as fixing the index/db2 bug that breaks on suddenly missing readKeys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant