-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathfinder doc / behavior issues #878
Comments
@avehtari Are you proposing just that we add a warning or change the behavior? @WardBrian @SteveBronder Is this also the case with the cmdstanpy implementation or did we end up doing something different here accidentally? |
We had discussions about automatically adjusting the num_single_draws to prevent this but Steve argued successfully that this would be too magic. Cmdstan got a warning for it in stan-dev/cmdstan#1221 |
Oh ok great, so this warning will get handled in CmdStan itself. |
I'm fine that the document is updated to reflect that it doesn't need to be smaller |
Ok instead of "This must be smaller than ‘single_path_draws * num_paths’." should we just say "This should be smaller than ‘single_path_draws * num_paths’ or CmdStan will throw a warning." Or something else? (Currently it won't throw a warning but sounds like next version will) |
@avehtari are you ok with changing the doc to "This should be smaller than ‘single_path_draws * num_paths’ or CmdStan will throw a warning."? (although the warning won't come until the next version of CmdStan) |
Yes |
Ok I updated the doc to
I will leave this issue open and wait to close it until the CmdStan with the warning is released (at that time I'll update the doc again). |
Adding here another pathfinder issue
|
Has this been fixed? |
I titled this issue as generic Pathfinder doc / behavior issues, not to make separate for each small issue
$pathfinder()
doc saysCurrent behavior is that this is by default 1000 which can be bigger than ‘single_path_draws * num_paths’ and also it can be set to value which is bigger than ‘single_path_draws * num_paths’, without any warning.
The text was updated successfully, but these errors were encountered: