From ac0e135fbc646fb5727f9095bcb1d9d0bf00cdaa Mon Sep 17 00:00:00 2001 From: Piotr Magiera <56825108+piotmag769@users.noreply.github.com> Date: Fri, 30 Aug 2024 13:45:29 +0200 Subject: [PATCH] LS: remove VFS update (#6311) --- crates/cairo-lang-language-server/src/lib.rs | 3 --- vscode-cairo/src/textDocumentProviders.ts | 7 ------- 2 files changed, 10 deletions(-) diff --git a/crates/cairo-lang-language-server/src/lib.rs b/crates/cairo-lang-language-server/src/lib.rs index c053ee12afb..070f21ccdf5 100644 --- a/crates/cairo-lang-language-server/src/lib.rs +++ b/crates/cairo-lang-language-server/src/lib.rs @@ -357,9 +357,6 @@ impl Backend { self.with_state_mut(|state| state.db.snapshot()).await } - // TODO(spapini): Consider managing vfs in a different way, using the - // client.send_notification:: call. - /// Refresh diagnostics and send diffs to client. #[tracing::instrument(level = "debug", skip_all)] async fn refresh_diagnostics(&self) -> LSPResult<()> { diff --git a/vscode-cairo/src/textDocumentProviders.ts b/vscode-cairo/src/textDocumentProviders.ts index 270805151d0..1a1ddfef2fe 100644 --- a/vscode-cairo/src/textDocumentProviders.ts +++ b/vscode-cairo/src/textDocumentProviders.ts @@ -4,8 +4,6 @@ import { Context } from "./context"; import { expandMacro, vfsProvide, viewAnalyzedCrates } from "./lspRequests"; export const registerVfsProvider = (client: lc.LanguageClient, ctx: Context) => { - const eventEmitter = new vscode.EventEmitter(); - const vfsProvider: vscode.TextDocumentContentProvider = { async provideTextDocumentContent(uri: vscode.Uri): Promise { const res = await client.sendRequest(vfsProvide, { @@ -14,13 +12,8 @@ export const registerVfsProvider = (client: lc.LanguageClient, ctx: Context) => return res.content ?? ""; }, - onDidChange: eventEmitter.event, }; - client.onNotification("vfs/update", (param) => { - eventEmitter.fire(param.uri); - }); - ctx.extension.subscriptions.push( vscode.workspace.registerTextDocumentContentProvider("vfs", vfsProvider), );