fix(macos): do not ignore errors on sending HTTP responses #1372
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rhysd <[email protected]>
amrbashir
reviewed
Sep 26, 2024
| "wry": patch | ||
| --- | ||
|
|
||
| On macOS, do not ignore errors on sending HTTP resopnses. Errors now cause panics. |
There was a problem hiding this comment.
I don't think our users would appreciate panics, we should instead just log::error the result
There was a problem hiding this comment.
Hmm, does it mean users can recover the error when it occurs? This is an internal error and users don't know why it happened. And there is no other way to receive a response via custom protocol. For unrecoverable errors, I believe panics are a correct way to handle them.
https://doc.rust-lang.org/beta/book/ch09-03-to-panic-or-not-to-panic.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All errors on sending HTTP responses are ignored on macOS.
wry/src/wkwebview/mod.rs
Line 345 in eafaadb
This PR changes to check the errors. When some error happens, it now causes a panic.