Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-open-pr Task private git server support #1288

Open
the-it-jaeger opened this issue Jul 3, 2024 · 2 comments
Open

github-open-pr Task private git server support #1288

the-it-jaeger opened this issue Jul 3, 2024 · 2 comments

Comments

@the-it-jaeger
Copy link

the-it-jaeger commented Jul 3, 2024

Expected Behavior

github-open-pr Task should be able to inject CA certificates for private git servers or allow insecure connections via ... , context = ssl._create_unverified_context()

Actual Behavior

You cannot connect to private git servers with private CA-signed certificates.

Steps to Reproduce the Problem

  1. Try to connect to a private git server by specifying it in the GITHUB_HOST_URL parameter
  2. Observe "certificate not trusted error" in Task output

Additional Info

You can work around this but customizing the Task and adding import ssl and then adding this to line 131: ... , context = ssl._create_unverified_context()

@the-it-jaeger
Copy link
Author

The work around could be optional and controlled by a boolean parameter.

It would be best to go a step further and add a ca-certs workspace that would allow the user to inject private CA certs so security is maintained.

@the-it-jaeger
Copy link
Author

I'll try to work on this if I get time, but it may not be for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant