Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Runtime Error log #4387

Closed
1 task done
tzzed opened this issue Aug 7, 2023 · 8 comments · Fixed by #4393
Closed
1 task done

Improve Runtime Error log #4387

tzzed opened this issue Aug 7, 2023 · 8 comments · Fixed by #4393

Comments

@tzzed
Copy link
Contributor

tzzed commented Aug 7, 2023

Is your feature request related to a problem / use case? Please describe.
When orion return Runtime Error (unknown attribute value type in DB: ) we don't know the attribute name

Describe the solution you'd like
Something like this.
Runtime Error (unknown attribute value type in DB: type on attribute "name")

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Describe why you need this feature
This simplify the debug.

Additional information
Add any other information, diagrams or screenshots about the feature request here.

Do you have the intention to implement the solution

  • Yes, but I will need help.
@tzzed tzzed added the backlog label Aug 7, 2023
@fgalan
Copy link
Member

fgalan commented Aug 8, 2023

Thanks for the feedback! I agree that adding the attribute name would make the log trace more useful.

As far as I have checked, that log trace is used in three places:

imagen

I would say that in them all the attribute name is accessible at caP->name, so the issue could be easy to implement. @tzzed maybe you could do the PR implementing it, please? Thanks!

@tzzed
Copy link
Contributor Author

tzzed commented Aug 8, 2023

I have seen, but I need to compile orion on mac M2 if it is possible or should compile on linux for more simplicity?

@fgalan
Copy link
Member

fgalan commented Aug 8, 2023

mac M2 is not a supported platform. Maybe it works, but we haven't tested it.

Maybe you could create a Linux-based virtual machine in your mac M2 system using some virtualization tool (VirtualBox, etc.)?

@mapedraza
Copy link
Collaborator

@tzzed Have a look to https://github.com/abiosoft/colima project. It allows to run containers virtualising the platform.

@tzzed
Copy link
Contributor Author

tzzed commented Aug 15, 2023

@fgalan should the PR only set the attrobute on LM_E(("Runtime Error (unknown attribute value type in DB: %d)" or all logs that contains LM_E(("Runtime Error (unknown attribute value type %d)" to have harmonized logs?

@fgalan
Copy link
Member

fgalan commented Aug 22, 2023

@fgalan should the PR only set the attrobute on LM_E(("Runtime Error (unknown attribute value type in DB: %d)" or all logs that contains LM_E(("Runtime Error (unknown attribute value type %d)" to have harmonized logs?

I see a PR has been raised for this issue. Let's continue discussion there.

@fgalan fgalan added this to the 3.11.0 milestone Aug 22, 2023
@fgalan
Copy link
Member

fgalan commented Aug 22, 2023

Fixed by PR #4393

@tzzed should this issue be closed or is there anything else pending, please?

@tzzed
Copy link
Contributor Author

tzzed commented Aug 22, 2023

It can be closed. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants