Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][IPC4] Incorrect CPC values for MTL #7268

Closed
kv2019i opened this issue Mar 14, 2023 · 5 comments
Closed

[BUG][IPC4] Incorrect CPC values for MTL #7268

kv2019i opened this issue Mar 14, 2023 · 5 comments
Assignees
Labels
bug Something isn't working as expected CPC CPS IPC4 Issues observed with IPC4 (same IPC as Windows) MTL Applies to Meteor Lake platform P2 Critical bugs or normal features
Milestone

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Mar 14, 2023

Describe the bug
The CPS/CPS values for MTL are incorrect for multiple modules. Currently the DSP FW does not adjust DSP speed based on this data, but when this feature is enabled, the incorrect data will lead to running DSP at too low/high frequency, leading to either audio artifacts, or too high power consumption.

To Reproduce
Need in-progress code for FW -> #7267

Reproduction Rate
100%

Expected behavior
Values should be closer to those used on mtl-004 branch of rimage

https://github.com/thesofproject/rimage/tree/mtl-004-drop-stable

96ed61016a6fb3551b6013ccbb0a4935ae494f07 (origin/mtl-004-drop-stable) mtl: fill in cps and cpc data for smart_amp_test  module
f59cf6fa05156ed9e5f404f2e599746d5e8573b5 mtl: fill in cps and cpc data for ASRC module
0bcef6fea4d9592d7d9ee4b5847c1960a97d6052 mtl: fill in subsequent measured cps and mcps data

FYI @abonislawski @mwasko @ujfalusi @lgirdwood @kfrydryx @pblaszko

@kv2019i kv2019i added bug Something isn't working as expected P2 Critical bugs or normal features IPC4 Issues observed with IPC4 (same IPC as Windows) MTL Applies to Meteor Lake platform labels Mar 14, 2023
@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 14, 2023

Note, updated titles, "struct ipc4_base_module_cfg" has only the CPC value, so CPS is not relevant here (unless it's used as a source to calculate CPC).

@kv2019i kv2019i changed the title [BUG][IPC4] Incorrect CPC/CPS values for MTL [BUG][IPC4] Incorrect CPC values for MTL Mar 14, 2023
@lgirdwood lgirdwood added this to the v2.6 milestone Mar 14, 2023
@lgirdwood lgirdwood modified the milestones: v2.6, v2.7 May 11, 2023
@mengdonglin
Copy link
Collaborator

Will update CPC value based on MCPS values captured in CI test.

@mengdonglin
Copy link
Collaborator

mengdonglin commented Aug 16, 2023

@alex-cri @lgirdwood @kv2019i @aiChaoSONG
Move to v2.8.
sof-test PR to measure performance in under review: thesofproject/sof-test#1090
It will take weeks to run extensive test before we can update CPC values in manifest.

@mengdonglin mengdonglin modified the milestones: v2.7, v2.8 Aug 16, 2023
@mengdonglin mengdonglin added performance Issues related to code performance and speed optimizations. CPC CPS and removed performance Issues related to code performance and speed optimizations. labels Aug 16, 2023
@btian1 btian1 self-assigned this Nov 8, 2023
@btian1
Copy link
Contributor

btian1 commented Nov 15, 2023

thesofproject/sof-test#1127

This is the PR under review, according to Liam's suggestion:
"Liam suggest to use max peak + 10% margin as clock scaling cannot bring much power saving unless using 38.4MHz WoV clock"

After this was merged, we can update part of module CPC based on CI performance data.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Nov 29, 2023

Closing this bug. the CPC (cycle budget per audio module) values are now close enough and there are no kernel warnings from missing values with mainline firmware and topology anymore. Continue maintenance of accurate CPC data with #8019 which is enabling DSP speed control driver by the cycle-budgets.

@kv2019i kv2019i closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected CPC CPS IPC4 Issues observed with IPC4 (same IPC as Windows) MTL Applies to Meteor Lake platform P2 Critical bugs or normal features
Projects
None yet
Development

No branches or pull requests

6 participants