Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Expose all members of high-level objects #57

Open
jo11he opened this issue Mar 3, 2022 · 1 comment
Open

Feature Request: Expose all members of high-level objects #57

jo11he opened this issue Mar 3, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jo11he
Copy link
Collaborator

jo11he commented Mar 3, 2022

I notice that the exposition of members of high-level objects is still quite incomplete. This leads to situations where the user is left clueless, e.g. when trying to retrieve environment parameters after a simulation (or estimation) from the environment.
One example I can give is the body object, which does for example not have its radiation_pressure_interface member exposed. I am sure there are many more instances of this.

There are more issues with this, namely that there is no RadiationPressureInterface class exposed in python, such that - even if the class was exposed as a member of body - the members of RadiationPressureInterface (or rather the parameters defining the instance of that class) are not accessible to the tudatpy user.
A good example of this is the aerodynamic_coefficient_interface, which is given as a member of the body class, but the AerodynamicCoefficientInterface class itself is inaccessible to the tudatpy user because it has not yet been exposed.

So in short: If you want to improve tudatpy and the docs that come with it (nicely linking all the connections between objects and their members), a makeover from this "completeness" point of view could be a good start.

@jo11he jo11he closed this as completed Mar 3, 2022
@jo11he jo11he reopened this Mar 3, 2022
@gaffarelj gaffarelj self-assigned this Mar 3, 2022
@gaffarelj gaffarelj added documentation-related Suggests that documentation needs enriching enhancement New feature or request and removed documentation-related Suggests that documentation needs enriching labels Mar 3, 2022
@gaffarelj
Copy link
Member

I can take care of this, little by little.

I do encourage anyone to drop new elements in this thread when they see that something is still missing, using checkboxes for each element to be exposed so that I can follow whether something has been done already or not.

(cc @DominicDirkx @FilippoOggionni @geoffreygarrett)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants