Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site - Layout grid: Mixin guidance doesn't match other utilities #2210

Open
2 tasks done
mahoneycm opened this issue Jul 24, 2023 · 3 comments · May be fixed by #2276
Open
2 tasks done

USWDS-Site - Layout grid: Mixin guidance doesn't match other utilities #2210

mahoneycm opened this issue Jul 24, 2023 · 3 comments · May be fixed by #2276
Assignees
@mahoneycm
Labels
Affects: Accessibility 🟡 Relates to the accessibility of our components Affects: Guidance Relates to guidance Role: Content Content/writing skills needed Type: Feature Request New functionality

Comments

@mahoneycm
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The layout grid mixin guidance does not follow patterns set by other utility classes and generally could be improved.

Describe the solution you'd like

Convert to mixin table similar to flex utility mixin guidance.

Describe alternatives you've considered

No response

Additional context

Screenshots

Layout grid
image

image

Display flex
image

Code of Conduct
@mahoneycm mahoneycm added the Type: Feature Request New functionality label Jul 24, 2023
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Jul 24, 2023
@amyleadem amyleadem added Affects: Guidance Relates to guidance and removed Status: Triage We're triaging this issue and grooming if necessary labels Jul 27, 2023
@amyleadem
Copy link
Contributor

amyleadem commented Jul 27, 2023 •
edited
Loading

@sarah-sch I've tagged you as the primary on this to get your feedback on if this should be changed, and if so, how. I've also tagged @mahoneycm because he is familiar with the issue and can help explain if needed.

@amyleadem amyleadem added the Role: Content Content/writing skills needed label Jul 27, 2023
@amyleadem amyleadem added the Affects: Accessibility 🟡 Relates to the accessibility of our components label Aug 7, 2023
@sarah-sch
Copy link
Contributor

Discussed with @amyleadem and @mahoneycm on 8/7/2023. Recommend revising layout grid guidance because current code-heavy format is not accessible. Discussed with Amy and Charle that urgency of task could be elevated to around 6.

@mahoneycm mahoneycm linked a pull request Sep 13, 2023 that will close this issue
Open
8 tasks
@amyleadem amyleadem added this to the 2023.4.3 November milestone Nov 6, 2023
@brunerae brunerae removed this from the 2023.11 November milestone May 13, 2024
@brunerae
Copy link
Contributor

@mahoneycm based on recent activity in the linked PR, I am moving this into our Sprint.

@mahoneycm mahoneycm mentioned this issue May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahoneycm mahoneycm

Labels
Affects: Accessibility 🟡 Relates to the accessibility of our components Affects: Guidance Relates to guidance Role: Content Content/writing skills needed Type: Feature Request New functionality
Projects
USWDS Core Project Data
Status: Fed Final Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

USWDS -Site - Layout Grid: Guidance refactor uswds/uswds-site
4 participants
@mahoneycm @brunerae @amyleadem @sarah-sch