Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Documentation: Improve clarity in sample layout settings #2611

Closed
mejiaj opened this issue Apr 10, 2024 · 5 comments · May be fixed by #2276
Closed

USWDS-Site - Documentation: Improve clarity in sample layout settings #2611

mejiaj opened this issue Apr 10, 2024 · 5 comments · May be fixed by #2276
Assignees
Labels
Affects: Guidance Relates to guidance

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Apr 10, 2024

From a ZenDesk question.

To turn on or off breakpoints as mentioned on this page
https://designsystem.digital.gov/utilities/layout-grid/#sass-mixins
, what is the name/location of the scss file that I should modify?

Problem

It's not clear where these settings should be added in the code examples.
image

Expected

A file name or more accurate example of how they are used should be added.

A possible solution:

+ /* _uswds-theme.scss */

// Values are set as units tokens.

- $theme-column-gap-sm:               2px;
-  $theme-column-gap-md:               2;
-  $theme-column-gap-lg:               3;
-  $theme-column-gap-mobile:           2;
-  $theme-column-gap-desktop:          4;
-  $theme-grid-container-max-width:    'desktop';
-  $theme-site-margins-breakpoint:     'desktop';
-  $theme-site-margins-width:          4;
-  $theme-site-margins-mobile-width:   2;

+@use "uswds-core" with (
+ $theme-column-gap-sm:               2px;
+  $theme-column-gap-md:               2;
+  $theme-column-gap-lg:               3;
+  $theme-column-gap-mobile:           2;
+  $theme-column-gap-desktop:          4;
+  $theme-grid-container-max-width:    'desktop';
+  $theme-site-margins-breakpoint:     'desktop';
+  $theme-site-margins-width:          4;
+  $theme-site-margins-mobile-width:   2;
+ )

Source: _utilities/layout-grid.md

@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Apr 10, 2024
@mejiaj mejiaj added the Affects: Guidance Relates to guidance label Apr 10, 2024
@mejiaj
Copy link
Contributor Author

mejiaj commented Apr 11, 2024

@amyleadem can you confirm if this was addressed in your existing refactor work?

@mejiaj mejiaj added Added during Sprint and removed Status: Triage We're triaging this issue and grooming if necessary labels Apr 11, 2024
@amyleadem
Copy link
Contributor

It looks like we haven't addressed this yet. We flagged it in the code documentation audit, but it has not yet been addressed. I've added a note in the spreadsheet that the item will be addressed in this issue.

@amyleadem amyleadem assigned mahoneycm and unassigned amyleadem May 20, 2024
@amyleadem
Copy link
Contributor

Re-assigning to @mahoneycm to see if it has been addressed in #2276

@mahoneycm
Copy link
Contributor

This issue should be completed as part of #2276 where we are discussing replacing this section with a link to the settings guidance or by capturing the relevant information in site.data.settings.spacing.contents

image

@mahoneycm
Copy link
Contributor

Closing in favor of #2210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Guidance Relates to guidance
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants